Cut off board/port name when greater than 50 #3185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for .hh and .hpp libraries
|
I believe allowing unlimited length is unwise. A very long string really mess up the menu. My original decision to limit to 16 chars was conservative. 16 seemed like a lot more than zero. Since this patch was "unofficial" for years, I didn't want to dramatically alter the menu size & appearance. Let's keep the limit, but raise it to something large, like 25 or 30 or even 40 chars. |
|
Agree. Let's turn it to a round 50 |
ffissore
changed the title
|
50 seems like as good a limit as any. If we later do run into GUI problems, the limit can always be adjusted. |
ffissore
added a commit
that referenced
this pull request
May 20, 2015
Cut off board/port name when greater than 50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3104
Please try the IDE resulting from this PR and express your (dis)agreement for
/cc @damellis